Re: [Qemu-devel] [PATCH 3/4] sockets: switch vnc to new code, support vnc port auto-allocation.

[Gerd Hoffmann]

Blue Swirl wrote:
> On 10/28/08, Gerd Hoffmann <address@hidden> wrote:
>> This patch switches the vnc code ofer to the new socket helper
>>  functions.
>>  -    if (strcmp(display, "none") == 0)
>>  -       return 0;
>>  -
>>      if (!(vs->display = strdup(display)))
>>         return -1;
>>  +    if (strcmp(display, "none") == 0)
>>  +       return 0;
> 
> Why this change?

To keep vs->display and thus the "info vnc" output up-to-date.  Without
this you'll see stale information after "change vnc none".

> It looks like it will leak memory if display is "none".

Oops, yes.  Will fix.

cheers,
  Gerd