[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging |
Date: |
Wed, 29 Oct 2008 20:53:08 +0100 |
User-agent: |
KMail/1.9.9 |
On Wednesday 29 October 2008, Blue Swirl wrote:
> Hi,
>
> When emulating a mixed 32/64 bit Qemu target CPUs it's easy to confuse
> the TCGv size, passing 32 bit TCGv to a function expecting a 64 bit
> one and vice versa. This patch adds a run time sanity check for TCGv
> sizes.
Would it make more sense to push these down into tcg_gen_op* ?
tcg-op.h is already fairly unwieldy.
I wonder if it's worth adding TCG_LOW to enable checking on 32-bit hosts.
For futureproofing I'd name things FOO_I32 rather than FOO_32.
Paul