Re: [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging

[Paul Brook]

On Wednesday 29 October 2008, Blue Swirl wrote:
> On 10/29/08, Paul Brook <address@hidden> wrote:
> > On Wednesday 29 October 2008, Blue Swirl wrote:
> >  > Hi,
> >  >
> >  > When emulating a mixed 32/64 bit Qemu target CPUs it's easy to confuse
> >  > the TCGv size, passing 32 bit TCGv to a function expecting a 64 bit
> >  > one and vice versa. This patch adds a run time sanity check for TCGv
> >  > sizes.
> >
> > Would it make more sense to push these down into tcg_gen_op* ?
>
> How? At that point we don't know what was the correct size.

I figure there's only a handful of different cases, so it'll be cleaner to 
introduce tcg_gen_op_i32_i32 etc. which trivially reduce to tcg_gen_op2 when 
debugging is disabled.

Paul