Re: [Qemu-devel] [PATCH, RFT] Update i386-dis.c from binutils 2.17

[Laurent Desnogues]

On Mon, Oct 27, 2008 at 7:29 PM, Blue Swirl <address@hidden> wrote:
>
> This very lightly tested patch updates i386-dis.c from binutils 2.17.
> If someone can test it more thoroughly and declare that the patch is
> useful and it does not break anything, I may apply it.

I made a quick run on x86_64 and the only difference in the trace
was the replacement of:

  mov    %rdx,(%r12)

to:

  mov    %rdx,(%r12,1)

I guess the extra 1 is a scaling factor that was previously omitted
(and which might be needed to distinguish two instructions that
have different object code).

Of course, my test doesn't mean the patch broke nothing, but it's
better than no test :-)


Laurent