[Qemu-devel] Re: [PATCH] linux-user, x86: use target_mmap() to allocate idt, gdt and ldt tables

[Kirill A. Shutemov]

On Sat, Nov 01, 2008 at 10:33:07AM +0100, Jan Kiszka wrote:
> Kirill A. Shutemov wrote:
> > env->*dt.base should fits target address space, so we should use
> > target_mmap to allocate it.
> 
> I just noticed that this bug is still unfixed upstream, was about to
> repost my corresponding patch [1], but then found this even nicer
> approach. Could someone please finally merge a fix?
> 
> Kirill, do you also have a patch for the problem [2] addresses in your
> queue?

No, I don't. But we also can use target_mmap(with my mmap_find_vma()) for
it, I guess. Can you provide any testcase to reproduce the bug?

> 
> Last time I posted my series, Anthony remarked that the role of the
> linux-user maintainer is vacant. My impression is that this is still the
> case while at the same time Kirill is doing quite a good job now getting
> this corner of qemu in shape again...... :->

I'm interested in commit access. I've already asked about it, but I haven't
got any responce.

I've attached ssh-key just in case. ;)

> 
> Jan
> 
> [1] http://permalink.gmane.org/gmane.comp.emulators.qemu/28386
> [2] http://permalink.gmane.org/gmane.comp.emulators.qemu/28385

<skip/>

> > @@ -283,9 +284,8 @@ static void write_dt(void *ptr, unsigned long addr, 
> > unsigned long limit,
> >      p[1] = tswap32(e2);
> >  }
> >  
> > +uint64_t *idt_table;
> 
> This should become static...

Updated patch has been sent.


-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

id_dsa.pub
Description: Text document

signature.asc
Description: Digital signature