qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH][RFC] Run time TCGv size check for debugging


From: Paul Brook
Subject: Re: [Qemu-devel] Re: [PATCH][RFC] Run time TCGv size check for debugging
Date: Sat, 1 Nov 2008 13:59:51 +0100
User-agent: KMail/1.9.9

> This version introduces TCGv_i32 and TCGv_i64. TCGv_ptr and TCGv (TL
> sized) are based on them.

This is looking good to me.

> For Sparc, the patch is very invasive (I just commented out the
> helpers to avoid that part)  but I think i386 would need much smaller
> changes.
>
> With the patch, I found some bugs in Sparc translation. I'm not sure
> what to do with helpers, there should be a way to declare the size of
> the arguments somehow and then the calling should be easier than:
> tcg_gen_helper_1_4_i64_tl_i32_i32_i32(helper_ld_asi, dst, addr, r_asi,
> r_size, r_sign);

I think we can build some infrastructure to make helpers easier to handle.  
It should be relatively mechanical changes to the existing helper[s].h.  ARM 
and m68k already do this, though need a bit more work to get static 
typechecking.  All the information it there's it's just not quite in the 
right form.  I'll see if I can dig out the CPP magic required for this.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]