Re: [Qemu-devel] Re: [PATCH] Fix alarm_timer race with select

[Anthony Liguori]

Jan Kiszka wrote:
> Anthony Liguori wrote:
>   
> > Anthony Liguori wrote:
> >     
> > > Jan Kiszka wrote:
> > >
> > > Perhaps we should move the alarm timer check rearming out of the main
> > > loop and into a qemu_set_fd_handler2() handler?
> > >       
> > And now that I think about it, I see no reason why the timer expiration
> > checks couldn't be moved to the same handler.  I'd have to look more
> > closely at how that would interact with icount though.
> >     
>
> I cannot yet follow you here. But I my impression is that this will be
> an additional change that should come in a separate patch, no?
>   

Yeah, I can take care of that.  This is general cleanup that I've wanted 
to do to the main loop.

> Find the O_NONBLOCK remark addressed below.
>   

Great!  I'll give it a spin.

Regards,

Anthony Liguori