Re: [Qemu-devel] [PATCH] correctly advertise presence of KVM support

[Glauber Costa]

On Wed, Nov 5, 2008 at 6:02 PM, Anthony Liguori <address@hidden> wrote:
> Glauber Costa wrote:
>>
>> We can fail in tests to enable kvm, for example,
>> if we are compiling to a target different from our host
>> platform. However, at that point, KVM support may have been
>> already advertised to the user. This is very misleading.
>>
>> So we first test it, and then advertise KVM support. To do that
>> without spliting the summary strings around the whole configure,
>> we move everything to the end, where nothing can change anymore
>>
>
> This isn't quite correct.  If you did something like:
>
> configure --target-list='x86_64-softmmu cris-softmmu'
>
> Then even though x86_64-softmmu may have KVM enabled, it's dumb luck whether
> or not you see KVM    yes in the configure output depending on which target
> gets configured first.
>
> I think we need something a bit more sophisticated like output for all of
> the targets with KVM enabled or something like that.
>
> For instance, consider if you did configure --target-list='x86_64-softmmu
> i386-softmmu cris-softmmu'

I agree it's better as a general solution. I was just thinking short
term. I'll rewrite it accordingly
>
> Regards,
>
> Anthony Liguori
>
>> Signed-off-by: Glauber Costa <address@hidden>
>> ---
>>  configure |  102
>> ++++++++++++++++++++++++++++++------------------------------
>>  1 files changed, 51 insertions(+), 51 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 65f0c74..8e11506 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1022,57 +1022,6 @@ else
>>   binsuffix="/bin"
>>  fi
>>  -echo "Install prefix    $prefix"
>> -echo "BIOS directory    $prefix$datasuffix"
>> -echo "binary directory  $prefix$binsuffix"
>> -if test "$mingw32" = "no" ; then
>> -echo "Manual directory  $prefix$mansuffix"
>> -echo "ELF interp prefix $interp_prefix"
>> -fi
>> -echo "Source path       $source_path"
>> -echo "C compiler        $cc"
>> -echo "Host C compiler   $host_cc"
>> -echo "ARCH_CFLAGS       $ARCH_CFLAGS"
>> -echo "make              $make"
>> -echo "install           $install"
>> -echo "host CPU          $cpu"
>> -echo "host big endian   $bigendian"
>> -echo "target list       $target_list"
>> -echo "gprof enabled     $gprof"
>> -echo "sparse enabled    $sparse"
>> -echo "profiler          $profiler"
>> -echo "static build      $static"
>> -echo "-Werror enabled   $werror"
>> -if test "$darwin" = "yes" ; then
>> -    echo "Cocoa support     $cocoa"
>> -fi
>> -echo "SDL support       $sdl"
>> -if test "$sdl" != "no" ; then
>> -    echo "SDL static link   $sdl_static"
>> -fi
>> -echo "curses support    $curses"
>> -echo "mingw32 support   $mingw32"
>> -echo "Audio drivers     $audio_drv_list"
>> -echo "Extra audio cards $audio_card_list"
>> -echo "Mixer emulation   $mixemu"
>> -echo "VNC TLS support   $vnc_tls"
>> -if test "$vnc_tls" = "yes" ; then
>> -    echo "    TLS CFLAGS    $vnc_tls_cflags"
>> -    echo "    TLS LIBS      $vnc_tls_libs"
>> -fi
>> -if test -n "$sparc_cpu"; then
>> -    echo "Target Sparc Arch $sparc_cpu"
>> -fi
>> -echo "kqemu support     $kqemu"
>> -echo "brlapi support    $brlapi"
>> -echo "Documentation     $build_docs"
>> -[ ! -z "$uname_release" ] && \
>> -echo "uname -r          $uname_release"
>> -echo "NPTL support      $nptl"
>> -echo "vde support       $vde"
>> -echo "AIO support       $aio"
>> -echo "KVM support       $kvm"
>> -
>>  if test $sdl_too_old = "yes"; then
>>  echo "-> Your SDL version is too old - please upgrade to have SDL
>> support"
>>  fi
>> @@ -1690,4 +1639,55 @@ if test "$source_path_used" = "yes" ; then
>>     done
>>  fi
>>  +echo "Install prefix    $prefix"
>> +echo "BIOS directory    $prefix$datasuffix"
>> +echo "binary directory  $prefix$binsuffix"
>> +if test "$mingw32" = "no" ; then
>> +echo "Manual directory  $prefix$mansuffix"
>> +echo "ELF interp prefix $interp_prefix"
>> +fi
>> +echo "Source path       $source_path"
>> +echo "C compiler        $cc"
>> +echo "Host C compiler   $host_cc"
>> +echo "ARCH_CFLAGS       $ARCH_CFLAGS"
>> +echo "make              $make"
>> +echo "install           $install"
>> +echo "host CPU          $cpu"
>> +echo "host big endian   $bigendian"
>> +echo "target list       $target_list"
>> +echo "gprof enabled     $gprof"
>> +echo "sparse enabled    $sparse"
>> +echo "profiler          $profiler"
>> +echo "static build      $static"
>> +echo "-Werror enabled   $werror"
>> +if test "$darwin" = "yes" ; then
>> +    echo "Cocoa support     $cocoa"
>> +fi
>> +echo "SDL support       $sdl"
>> +if test "$sdl" != "no" ; then
>> +    echo "SDL static link   $sdl_static"
>> +fi
>> +echo "curses support    $curses"
>> +echo "mingw32 support   $mingw32"
>> +echo "Audio drivers     $audio_drv_list"
>> +echo "Extra audio cards $audio_card_list"
>> +echo "Mixer emulation   $mixemu"
>> +echo "VNC TLS support   $vnc_tls"
>> +if test "$vnc_tls" = "yes" ; then
>> +    echo "    TLS CFLAGS    $vnc_tls_cflags"
>> +    echo "    TLS LIBS      $vnc_tls_libs"
>> +fi
>> +if test -n "$sparc_cpu"; then
>> +    echo "Target Sparc Arch $sparc_cpu"
>> +fi
>> +echo "kqemu support     $kqemu"
>> +echo "brlapi support    $brlapi"
>> +echo "Documentation     $build_docs"
>> +[ ! -z "$uname_release" ] && \
>> +echo "uname -r          $uname_release"
>> +echo "NPTL support      $nptl"
>> +echo "vde support       $vde"
>> +echo "AIO support       $aio"
>> +echo "KVM support       $kvm"
>> +
>>  rm -f $TMPO $TMPC $TMPE $TMPS $TMPI
>>
>
>
>
>



-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."