[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update |
Date: |
Fri, 07 Nov 2008 09:44:13 +0100 |
Le jeudi 06 novembre 2008 à 12:53 -0600, Anthony Liguori a écrit :
> Laurent Vivier wrote:
> > This series of patches improves qcow2 performance with O_DIRECT
> > when the qcow2 file is empty and we begin to fill it.
> >
>
> I really dislike this series and any future series that does similar
> things. The real problem is that non-aligned accesses are so slow, but
> there's no reason that they must be so slow. It's because we're doing
> synchronous IO operations instead of using posix-aio like we should.
> That's the real problem. Just doing a memory copy to an aligned buffer
> is not going to cause that much performance delay.
>
> We shouldn't be adding more cruft to the code base to avoid fixing the
> real problem. I think the current implementation of O_DIRECT needs to
> be rewritten.
Like any good maintainer, you are becoming a tyrant...
BTW, patch #1 is a clean-up (no change, only code move) and patch #2
doesn't align buffer, but try to minimise syscall (it improves
performance with O_DSYNC too).
Ignore patch #3 and #4 if you dislike them.
Regards,
Laurent
--
------------------ address@hidden ------------------
"Tout ce qui est impossible reste à accomplir" Jules Verne
"Things are only impossible until they're not" Jean-Luc Picard
- [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Laurent Vivier, 2008/11/06
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Anthony Liguori, 2008/11/06
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Kevin Wolf, 2008/11/07
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update,
Laurent Vivier <=
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Anthony Liguori, 2008/11/07
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Laurent Vivier, 2008/11/07
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Anthony Liguori, 2008/11/07
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Laurent Vivier, 2008/11/07
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Avi Kivity, 2008/11/09
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Anthony Liguori, 2008/11/09
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Andreas Färber, 2008/11/10
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Improve cluster refcount update, Anthony Liguori, 2008/11/10