[Qemu-devel] Re: [PATCH] fix warnings on NetBSD

[Blue Swirl]

On 11/10/08, Christoph Egger <address@hidden> wrote:
> On Monday 10 November 2008 17:03:27 Blue Swirl wrote:
>  > On 11/10/08, Christoph Egger <address@hidden> wrote:
>  > >  Hi!
>  > >
>  > >  Attached patch fixes a series of this warning
>  > >  when compiling on NetBSD:
>  > >
>  > >  warning: array subscript has type 'char'
>  >
>  > There has been some discussion on ctype.h macro problems, please see:
>  > http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01239.html
>  >
>  > I'd vote for introducing qemu_isfoobar and qemu_towombat instead of casts.
>
>
> Attached patch introduces a CTYPE macro as mentioned on this mail.
>  The diff in qemu-common.h has been taken from xen ioemu.

Sorry, you must have missed the two follow-up messages:
http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01252.html
http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01292.html

So instead of CTYPE macro, there should be qemu_toupper, qemu_isalpha
etc. which handle char arguments correctly even when sign extension
happens.