Re: [Qemu-devel] [PATCH] DM9000 network card driver

[Blue Swirl]

On 11/11/08, Daniel Silverstone <address@hidden> wrote:
> On Mon, 2008-11-10 at 18:47 +0200, Blue Swirl wrote:
>  > >  I appreciate that you're all busy, so if the answer is simply "You're on
>  > >  the list, just it'll be a while" then at least I can carry that back to
>  > >  my boss who wants to know how it's going getting these patches to you.
>
> > Your patch looks very clean. I wouldn't use devices.h for the
>  > prototype, but instead some board file (for example arm-misc.h).
>
>
> I think I was told to use devices.h quite a while back. It's not
>  appropriate to put it in arm-misc.h since the device itself has no
>  specific isolation in ARM stuff. Despite being made to put the HW in the
>  ARM HW bits of the Makefile.

I see. Then devices.h seems correct. I was wondering about NEED_CPU stuff.

>  > The device is not used by any board, so it's not possible even for the
>  > maintainer to test the patch.
>
>
> It is used by the board I am trying to get all the patches up-to-snuff
>  for.

Maybe you could add it as an ISA device to PC (pc.c) and see if it works?

>  > As there is a reset function already, it should not be too difficult
>  > to register that for system_reset use.
>
>
> Can you explain what you mean by that?

Just add a line like
qemu_register_reset(dm9000_hard_reset, state);
to dm9000_init().

Then if the machine gets reset by monitor command "system_reset" or a
hardware device,  the reset function will be called to make the device
state predictable like on a real machine.