Re: [Qemu-devel] [5675] target-mips: optimize gen_save_pc()

[Aurélien Jarno]

On Tue, Nov 11, 2008 at 05:59:41PM +0100, Andreas Färber wrote:
>
> Am 11.11.2008 um 12:36 schrieb Aurelien Jarno:
>
>> Revision: 5675
>>          http://svn.sv.gnu.org/viewvc/? 
>> view=rev&root=qemu&revision=5675
>> Author:   aurel32
>> Date:     2008-11-11 11:36:04 +0000 (Tue, 11 Nov 2008)
>>
>> Log Message:
>> -----------
>> target-mips: optimize gen_save_pc()
>>
>> We obviously don't need to use a temporary variable to write PC.
>
> We probably don't need an inline helper for that either, while we're at 
> it?

Well, the fact that we have an helper doesn't change the TCG generated
code, and shouldn't change the host generated code if GCC is used with
optimisation.

I am not sure it worth removing this function, I'll let the decision to
Thiemo.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net