[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] r5531 made x509 certs not loadable [PATCH]
From: |
andrzej zaborowski |
Subject: |
Re: [Qemu-devel] r5531 made x509 certs not loadable [PATCH] |
Date: |
Wed, 12 Nov 2008 17:53:01 +0100 |
2008/11/12 Henrik Holst <address@hidden>:
> The patch in r5531 which replaced a bunch of strncpy with pstrcpy causes
> the x509 credentials from the -vnc parameter to be one character shorter
> than entered meaning that there is currently no way to enter x509
> certificates...
>
> The attached patch fixes this. Also the path[len]='\0' is unnecessary
> now that pstrcpy is used. The problem was that the previous strncpy was
> called correctly which the r5531 patch didn't think. And due to how the
> code is a memcpy could probably be used instead...
Thanks for spotting. I made it a qemu_strndup instead because that's
basically what's being implemented here (to be exact it could be a
memdup() here because the length is already known). Please test.
Cheers