[Qemu-devel] Re: [PATCH 1/5] Re-factor nic model listing

[Anthony Liguori]

Mark McLoughlin wrote:
> Add a nic_models() method to QEMUMachine and move the nic model
> listing from hw/pc.c to vl.c.
>
> pci_nic_models() is hooked up to all machines which use
> pci_nic_init().
>
> The isapc machine is the only one which is slightly different
> since it only supports the ne2k_isa model.
>   

In principle, I think this patch series is a good idea.  I think the 
abstraction here is a little broken.

I don't think it's correct to associate nics directly with a machine 
type.  Rather, nics have bus requirements (like PCI, ISA, or USB) and a 
machine may or may not contain that bus.

Regards,

Anthony Liguori