Re: [Qemu-devel] [PATCH 1/5] Re-factor nic model listing

[Paul Brook]

On Thursday 13 November 2008, Anthony Liguori wrote:
> Paul Brook wrote:
> > On Thursday 13 November 2008, Mark McLoughlin wrote:
> >>      .desc = "ARM Versatile/PB (ARM926EJ-S)",
> >>      .init = vpb_init,
> >>      .use_scsi = 1,
> >> +    .nic_models = pci_nic_models,
> >
> > This is wrong, an I'd expect a lot of the other non-PC machines are too.
>
> What's the issue?  This board seems to have a PCI bridge attached to it
> so why can't it support any PCI nic?  Is this just not something that
> occurs naturally?

For the same reason you mentioned separately: The abstraction is all wrong. 
These boards also support various non-pci NICs. Admittedly this is a 
pre-existing bug, but if we're changing things it makes sense to get it 
right.

Paul