qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bochs-developers] [Qemu-devel] [PATCH v4 1/5] Add S3 state toDSDT.


From: Gleb Natapov
Subject: Re: [Bochs-developers] [Qemu-devel] [PATCH v4 1/5] Add S3 state toDSDT. Handle resume event in the BIOS.
Date: Sun, 16 Nov 2008 20:01:29 +0200

On Sun, Nov 16, 2008 at 06:54:38PM +0100, Sebastian Herbszt wrote:
> Gleb Natapov wrote:
>> On Sun, Nov 16, 2008 at 12:50:55PM +0200, Blue Swirl wrote:
>>> On 11/16/08, Gleb Natapov <address@hidden> wrote:
>>> >  +void s3_resume_panic()
>>>
>>> How about rather:
>>> void s3_resume_panic(void)
>>>
>>> >  +int
>>> >  +s3_resume()
>>>
>>> s3_resume(void)?
>>
>> Have you tried it? :)
>>
>> Hint: bcc doesn't support ANSI-C.
>
> It accepts some ansi-c with "-ansi". Man page says
> "-ansi  Pass  the  C  source  through unprotoize after preprocessing and
> before code generation. This will allow some ansi C to be compiled but
> it is definitly NOT a true ansi-C compiler."
>
But BOCHS doesn't use this flag. Do you what to add it and fix all
function prototypes? Seems like to much work for a little gain.


--
                        Gleb.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]