Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support

[Hollis Blanchard]

On Mon, 2008-11-17 at 22:30 +0100, François Revol wrote:
> > -    /* TODO: Implement compressed images.  */
> > -    if (hdr->ih_comp != IH_COMP_NONE) {
> > -        fprintf(stderr, "Unable to load compressed u-boot images\
> > n");
> > +    /* TODO bzip2 support */
> > +    if (hdr->ih_comp == IH_COMP_BZIP2) {
> > +        fprintf(stderr, "Unable to load bzip2 compressed u-boot 
> > images\n");
> 
> Shouldn't it still be testing for !=NONE && !=GZIP ?
> In case the header is incorrect or new compressions are added ?

I don't see what you mean about the header being incorrect, but I agree
on the second point. I'll make this change.

-- 
Hollis Blanchard
IBM Linux Technology Center