qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change
Date: Thu, 20 Nov 2008 13:01:32 -0600
User-agent: Thunderbird 2.0.0.17 (X11/20080925)

Hi Stefano,

Stefano Stabellini wrote:
Hi all,
this is an update of the "DisplayState interface change" patch.
The main change is introducing a DisplaySurface struct and a PixelFormat
struct following Anthony's suggestion, they are both inspired by SDL.

I must say that now everything looks much better, Anthony was definitely
right about the fact that we make too many assumptions based only on depth.
Introducing these two structures allowed me also to simplify vnc.c, as
you can see in the second patch.

I tested this series with i386 emulation, cirrus vga, vmware vga, curses
and both sdl and vnc (even at the same time ;).

I realize that the first patch is very big, but it is a small as
possible while still being able to compile.
I suggest you to read it on a per file basis, paying attention to the
changes to console.c, console.h, vga.c, vl.c, vnc.c and sdl.c; the rest
are just substitutions.

I really like this new API. I took a high level look at the code and I think there are only some minor things to be cleaned up but I'd rather you split up the first patch like I mentioned before pointing those things out.

One thing that I think would be helpful is to add a concise document describing how to use this new API. We can even introduce a docs directory for this sort of thing (think Documentation/ in Linux).

Regards,

Anthony Liguori

Cheers,

Stefano








reply via email to

[Prev in Thread] Current Thread [Next in Thread]