qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change


From: Stefano Stabellini
Subject: Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change
Date: Fri, 21 Nov 2008 17:45:16 +0000
User-agent: Thunderbird 2.0.0.14 (X11/20080505)

Paul Brook wrote:

> On Friday 21 November 2008, Stefano Stabellini wrote:
>> + Â  Â  Â  Â surface->data = (uint8_t*) qemu_reallocz(surface->data,
>> surface->linesize * surface->height); 
>> + Â  Â else 
>> + Â  Â  Â  Â surface->data = (uint8_t*) qemu_mallocz(surface->linesize *
>> surface->height);
> 
> Do these really need to be zeroed? 
> 
> reallocz seems like a bit of a funny concept. I doubt it's more efficient 
> than 
> free/mallocz. The point of normal realloc is that is preserves the contents 
> of the block, even if it moves.
> 

Actually I think they don't need to be, I have been probably overzelous.
I'll do some tests to be sure, then I'll drop it.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]