Re: [Qemu-devel] [RFC] Floppy controller: break relation with PC-style DMA

[Blue Swirl]

On 11/22/08, Hervé Poussineau <address@hidden> wrote:
> Hi,
>
>  Currently, floppy disk controller is tied to PC-style DMA controller.
>  Attached patch is an attempt to break the link between those, by
> introducing function pointers for dma operations (read, write, hold,
> release).
>
>  This will allow me to fix fdc DMA handling on MIPS Magnum/Acer Pica 61,
> where fdc is connected to rc4030 DMA controller.

Isn't it possible to move the i8257 DMA helpers to for example dma.c?
Then I could eliminate some dummy DMA_xx functions from sun4m.c and I
think fdctrl_i8257_init would not be needed.

You are calling fdctrl->dma_memory_write and _read without checking
that they are not NULL.