[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute
From: |
Thiemo Seufer |
Subject: |
Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute |
Date: |
Sun, 30 Nov 2008 14:11:07 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Jan Kiszka wrote:
> Avi Kivity wrote:
> > Jan Kiszka wrote:
> >>> Breaking the standard is what brings us the joys of recently (re)posted
> >>> patch for NetBSD and [u]intXX fun.
> >>>
> >>
> >> I have no problem with calling it 'noreturn' instead.
> >>
> >
> > That will break code that wants to use 'noreturn' as a local variable.
> > I think ATTR_NORETURN, while a lot uglier, is safer.
>
> Do you have such code already? Is it exported beyond qemu scope? Then
> why not going for our own convention "'noreturn' is reserved as function
> attribute"? (And yes, your macro is ugly :) ).
"Macro names should be in upper case" is also a useful convention.
FWIW, I agree with Stefan, there's currently not much need to isolate
gcc-isms.
Thiemo
- [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, (continued)
- [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Jan Kiszka, 2008/11/28
- Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Thiemo Seufer, 2008/11/28
- Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Avi Kivity, 2008/11/30
- Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Stefan Weil, 2008/11/30
- Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Laurent Desnogues, 2008/11/30
- [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Jan Kiszka, 2008/11/30
- Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Stefan Weil, 2008/11/30
- Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Andreas Färber, 2008/11/30
- Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, M. Warner Losh, 2008/11/30
- [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Jan Kiszka, 2008/11/30
- Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute,
Thiemo Seufer <=
- Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute, Jan Kiszka, 2008/11/30