qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] mmap: add check if requested memory area fits t


From: Kirill A. Shutemov
Subject: Re: [Qemu-devel] [PATCH] mmap: add check if requested memory area fits target address space
Date: Sat, 6 Dec 2008 22:00:45 +0200
User-agent: Mutt/1.5.18 (2008-10-30)

On Sat, Dec 06, 2008 at 08:46:10PM +0100, Edgar E. Iglesias wrote:
> On Wed, Dec 03, 2008 at 01:29:43PM +0200, Kirill A. Shutemov wrote:
> > Signed-off-by: Kirill A. Shutemov <address@hidden>
> > ---
> >  linux-user/mmap.c |   10 ++++++++++
> >  1 files changed, 10 insertions(+), 0 deletions(-)
> > 
> > diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> > index d96917d..52e2dc8 100644
> > --- a/linux-user/mmap.c
> > +++ b/linux-user/mmap.c
> > @@ -389,6 +389,16 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, 
> > int prot,
> >          end = start + len;
> >          real_end = HOST_PAGE_ALIGN(end);
> >  
> > +   /*
> > +    * Test if requested memory area fits target address space
> > +    * It can fail only on 64-bit host with 32-bit target.
> > +    * On any other target/host host mmap() handles this error correctly.
> > +    */
> > +        if ((unsigned long)start + len - 1 > (abi_ulong) -1) {
> > +            errno = EINVAL;
> > +            goto fail;
> > +        }
> > +
> >          for(addr = real_start; addr < real_end; addr += TARGET_PAGE_SIZE) {
> >              flg = page_get_flags(addr);
> >              if (flg & PAGE_RESERVED) {
> 
> Acked-by: Edgar E. Iglesias <address@hidden>
 
Thanks.

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.org/

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]