Re: [Qemu-devel] [PATCH] rename vlan to vnet and mark vlan as deprecated

[Anthony Liguori]

Gildas wrote:
> > Introducing an alias for something as core as vlan support is not all that
> > useful.  We're never going to implement the vlan option.
> >
> > All of the internal references are for vlan too.
> >
> > Regards,
> >
> > Anthony Liguori
> >     
>
> I think that keeping backward compatibility is a good idea and I'm ok
> to remove the warning message even though I don't think it does any
> harm.  I will modify the patch to document the fact that vlan=  is not
> IEEE 902.1q and that vnet= is the prefered option.
>   

If we're going to switch to vnet= (and I don't think we should), then it 
should be with a flag day.  And all at once conversion that changes 
internal and external references.

> I really think that it's a change that should done, both in the code
> and usage as both will greatly benefit from a move to VNET. Just look
> at the actual naming mess in e1000.c where real 802.1q handling takes
> place as well...
>   

I think this may cause minor confusion for a very small number of 
people, but for most people, who probably have no idea what 802.1q is, 
it never is an issue.

This is only the second time I've seen someone get confused by vlan= 
since the syntax was introduced.  It's really not a big deal AFAICT.

Regards,

Anthony Liguori

> Regards,
> Gildas
>
>
>