Re: [Qemu-devel] [PATCH] rename vlan to vnet and mark vlan as deprecated

[Daniel P. Berrange]

On Tue, Dec 09, 2008 at 10:40:25AM -0600, Anthony Liguori wrote:
> Kristoffer Ericson wrote:
> >On Tue, 09 Dec 2008 09:29:49 -0600
> >Anthony Liguori <address@hidden> wrote:
> >
> >  
> >>Gildas wrote:
> >>    
> >>>Hi all,
> >>>
> >>>As I agree with the thread "vlan option is misleading, what about vnet
> >>>?" and I found sending a patch would be more constructive than a "+1",
> >>>here it is.
> >>>  
> >>>      
> >>I don't think this is a good idea.  vlan has been the option name for a 
> >>long time and changing it now will lead to quite a lot of confusion.  I 
> >>agree that it's not perhaps the best name but it's too late now to 
> >>change it.
> >>    
> >
> >I understand your point but keeping something that
> >"everyone" agrees is misleading (myself included) just
> >because it's been used in the past is silly.
> >  
> 
> I don't think everyone agrees.  I think most people haven't even weighed 
> in.  What QEMU implements is a VLAN.  The term vlan existed long before 
> 802.11q.  It is not the only way to create a VLAN, just one of the more 
> common ones today.
> 
> QEMU's usage of vlan is actually correct.

So this basically says the key failing is the documentation we have 
for the vlan= option. If people are getting confused by what QEMU
is doing and its (non-)relation to 801.11q, then we need something
to clarify this in the docs rather than changing the name of option.
Since changing the name isn't really explaining things any better

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|