[Qemu-devel] Re: [PATCH] sh4: Followup to commit #5849 "Change MMIO callbacks..."

[Vladimir Prus]

address@hidden wrote:

> Thank you, Paul.
> 
>> You should not rely on overlapping regions doing anything sensible.
> OK. fixed.
> 
>> Proably simpler to just use a single region for both.
> Ah, that's right. Now the code is very simple (than I have expected).
> 
> Here is the patch. Please apply it.
> 
> Fixes to be needed for commit #5849 "Change MMIO callbacks..."
>   hw/sh7750.c:
>    - Divide region of CPU control registers to avoid overlapping
>      to peripheral modules.
>    - Delete unused var "icr", which had moved to hw/sh_intc.c.

Does sh_intc.c actually handle icr right now? Although I have a local
patch that makes it handle icr0 as well as LVLMODE, I don't see this
patch in SVN HEAD of qemu.

- Volodya