qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/13] Cleanup some logging code


From: Hollis Blanchard
Subject: Re: [Qemu-devel] [PATCH 00/13] Cleanup some logging code
Date: Wed, 10 Dec 2008 15:37:10 -0600

On Wed, 2008-12-10 at 16:24 -0200, Eduardo Habkost wrote:
> The following patches are small cleanups of the logging code on multiple
> partes of qemu. Most of them are for removing duplicated code and #ifdefs
> from the code. The patches are available on a git tree (see pull request
> below).
> 
> My long-term plan is to have a propper logging API on qemu, instead of
> the global variables 'loglevel' and 'logfile'. These cleanups should
> make that work easier, in addition to the code readability improvement.

Sounds good to me. You might want to look at GRUB2's grub_dprintf(),
which has proven invaluable for low-level remote debugging. Basically
you can just tell someone to run "set debug=disk" at runtime to enable
the "disk" class of debug output. Other classes include partition map,
ELF loading, filesystems, etc. It's nothing revolutionary, but it's been
really really useful.

-- 
Hollis Blanchard
IBM Linux Technology Center





reply via email to

[Prev in Thread] Current Thread [Next in Thread]