qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PROPOSITION] SH4 workflow improvement


From: Shin-ichiro KAWASAKI
Subject: Re: [Qemu-devel] [PROPOSITION] SH4 workflow improvement
Date: Fri, 12 Dec 2008 01:24:17 +0900
User-agent: Thunderbird 2.0.0.18 (Windows/20081105)

Paul Mundt wrote:
On Wed, Dec 10, 2008 at 03:04:12AM +0900, address@hidden wrote:
Thank you, Jean for your effort.

        My idea is to create a git repos to coordinate the SH4 patches
I believe this helps people testing new code easily.
It is much better than my bulk patch.

But, as you said
        The final goal is allow us to have a patch series on which we can send
        a pull request to have it applied in the SVN
This workflow, and the person who actually apply it, is important.
Otherwise this will be a forked project, and possibly affect negatively,
 discouraging people to merge sh patches to official repository.

It makes sense to have a staging tree where stuff can be queued up,
tested, and reworked until it is merged upstream. For the development of
new features, it is helpful to prevent fragmentation. We've already seen
this with at least 3 different people working on CF at basically the same
time without any knowledge of what was going on, this is something we
want to avoid.

Hm, staging tree seems to have two roles.
- Make it easy to review/test qemu-sh patches,
  so that high quality patches are sent to upstream.
- Avoid work duplications among qemu-sh developers.
And the drawbacks are,
- Might discourage merge to upstream.
- Messy to send patch both upstream and staging.

In any event, I would also like to start using QEMU for other SH targets,
not strictly limited to SH-4/SH-4A, which requires a bit of rework,
especially for SH-2A.
SH-2A sounds Exciting!


I have added your git repos as a remote branch here, but I found I don't have
 enough time to work with two repository.
So, I think I'm going to post mainly to ML even in future.

Work aimed at a staging tree is intended to be merged, not for long-term
out-of-tree development. Having said that, the staging tree itself should
never be in a situation where it is that badly out of sync with upstream
that getting patches applied becomes problematic. Effort should certainly
be concentrated on qemu-devel and the central SVN.

Even though I'm not yet sure the staging tree will work fine or not,
I'll try to use the repository 'http://repo.or.cz/w/qemu/sh4.git'
to push my patches.
# I'm going to work for U-Boot trouble on qemu-sh.

I want to make a correction.
The last commit with id f7a1672bb130d481c49dbea3f95f9649c03138f8
is not my work, but Yoshii-san's nice work.
I've just edited his patch to make it apply to the SVN HEAD.


Regards,
Shin-ichiro KAWASAKI






reply via email to

[Prev in Thread] Current Thread [Next in Thread]