Re: [Qemu-devel] screendump broken

[malc]

On Thu, 11 Dec 2008, Alexander Graf wrote:

> I haven't bisected this one, but when I call "screendump <file>" in
> current svn, I get a segfault:
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x000000000042e7c8 in vga_draw_glyph9_32 (d=0x0, linesize=<value
> optimized out>, font_ptr=0x7fcab68f6802 "", h=<value optimized out>,
> fgcol=<value optimized out>,
>    bgcol=0, dup9=0) at /suse/agraf/work/svm/qemu/hw/vga_template.h:135
> 135            ((uint32_t *)d)[0] = (-((font_data >> 7)) & xorcol) ^ bgcol;
> (gdb)
>
> It has probably been introduced within the last month.

It was broken much longer than that.. Here's something that worked
a while ago:

diff --git a/hw/vga.c b/hw/vga.c
index 9540db0..cbba46d 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -2453,6 +2453,7 @@ static void vga_screen_dump(void *opaque, const char 
*filename)

     s->ds = ds;
     s->graphic_mode = -1;
+    vga_save_dpy_resize (ds, saved_ds->width, saved_ds->height);
     vga_update_display(s);

     if (ds->data) {


--
mailto:address@hidden