qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 0/2] Eliminate references to logfile/logleve


From: Dor Laor
Subject: Re: [Qemu-devel] [RFC PATCH 0/2] Eliminate references to logfile/loglevel global vars
Date: Sat, 13 Dec 2008 00:27:39 +0200
User-agent: Thunderbird 2.0.0.18 (X11/20081119)

Eduardo Habkost wrote:
Hi,

This is actually a long 63-patch series, but for a first request for comments,
I am splitting it in two parts:

1) A set of macros are introduced for almost all usage patterns of the
   logfile/loglevel global variables.
2) 62 patches that convert almost all references to the logfile/loglevel
   global variables to use those macros (the PATCH 1/2 e-mail actually
   has pointers to the patches, either as small individual patches,
   or as a big single patch file).

These macros are _not_ a proposal for a definitive new logging API. They
are just a step for it: a way to group all usage patterns of the
logfile/loglevel variables on a single place. After all usage of those
variables is eliminated, we can more easily refactor the code to have
a proper logging API.

This series needs my previous debugging-#ifdef cleanup series to be applied
before it.

It shouldn't change any qemu behavior, but just move all references
to the logging global variables to a single place, keeping exactly the
same behaviour.

It is a blessed addition.

What about providing configure option to enable all the debug #ifdef?
Once we have it, we can set the debug level using the monitor for all debug
targets. For kvm is shouldn't introduce a measurable overhead since
it mostly uses the device model. It will be also ease debugging qemu
when there is no clue about the root cause it hard to predict at compile time.

We can have something like ./configure --full-debug
and #ifdef (FULL_DEBUG || DEBUG_IO_PORTS) for example.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]