[Qemu-devel] [6017] Correctly initialize msr list in KVM

[Anthony Liguori]

Revision: 6017
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6017
Author:   aliguori
Date:     2008-12-13 20:41:58 +0000 (Sat, 13 Dec 2008)

Log Message:
-----------
Correctly initialize msr list in KVM

I believe this was spotted by Gerd Hoffman but I can't find his patch 
now.  This will cause very subtle corruption on the heap because we 
don't allocate the appropriately sized buffer.

Signed-off-by: Anthony Liguori <address@hidden>

Modified Paths:
--------------
    trunk/target-i386/kvm.c

Modified: trunk/target-i386/kvm.c
===================================================================
--- trunk/target-i386/kvm.c     2008-12-13 19:27:22 UTC (rev 6016)
+++ trunk/target-i386/kvm.c     2008-12-13 20:41:58 UTC (rev 6017)
@@ -90,11 +90,11 @@
 
         /* Obtain MSR list from KVM.  These are the MSRs that we must
          * save/restore */
+        msr_list.nmsrs = 0;
         ret = kvm_ioctl(env->kvm_state, KVM_GET_MSR_INDEX_LIST, &msr_list);
         if (ret < 0)
             return 0;
 
-        msr_list.nmsrs = 0;
         kvm_msr_list = qemu_mallocz(sizeof(msr_list) +
                                     msr_list.nmsrs * 
sizeof(msr_list.indices[0]));
         if (kvm_msr_list == NULL)