Re: [Qemu-devel] [PATCH] target-ppc: fix fsel instruction

[Aurelien Jarno]

On Sat, Dec 13, 2008 at 05:49:10PM -0800, Nathan Froyd wrote:
> Fix fsel instruction.  Eliminate unneeded temporaries while we're at it,
> too.
> 
> Signed-off-by: Nathan Froyd <address@hidden>

Thanks, applied.

> ---
>  target-ppc/op_helper.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c
> index a9b7f73..92c6269 100644
> --- a/target-ppc/op_helper.c
> +++ b/target-ppc/op_helper.c
> @@ -1592,16 +1592,14 @@ uint64_t helper_frsqrte (uint64_t arg)
>  /* fsel - fsel. */
>  uint64_t helper_fsel (uint64_t arg1, uint64_t arg2, uint64_t arg3)
>  {
> -    CPU_DoubleU farg1, farg2, farg3;
> +    CPU_DoubleU farg1;
>  
>      farg1.ll = arg1;
> -    farg2.ll = arg2;
> -    farg3.ll = arg3;
>  
>      if (!fpisneg(farg1.d) || iszero(farg1.d))
> -        return farg2.ll;
> +        return arg2;
>      else
> -        return farg2.ll;
> +        return arg3;
>  }
>  
>  uint32_t helper_fcmpu (uint64_t arg1, uint64_t arg2)
> -- 
> 1.6.0.5
> 
> 
> 
> 

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net