Re: [Qemu-devel] [PATCH 03/42] target-ppc: add gen_avr_ptr function.

[Aurelien Jarno]

On Sun, Dec 14, 2008 at 06:14:36PM -0800, Nathan Froyd wrote:
> 
> Signed-off-by: Nathan Froyd <address@hidden>
> ---
>  target-ppc/translate.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 70047c7..41ae158 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -6053,6 +6053,13 @@ GEN_HANDLER2(icbt_440, "icbt", 0x1F, 0x16, 0x00, 
> 0x03E00001, PPC_BOOKE)
>  /***                      Altivec vector extension                         
> ***/
>  /* Altivec registers moves */
>  
> +static always_inline TCGv_ptr gen_avr_ptr(int reg)
> +{
> +    TCGv_ptr r = tcg_temp_new();
> +    tcg_gen_addi_ptr(r, cpu_env, offsetof(CPUPPCState, avr[reg]));
> +    return r;
> +}
> +
>  #define GEN_VR_LDX(name, opc2, opc3)                                         
>  \
>  GEN_HANDLER(name, 0x1F, opc2, opc3, 0x00000001, PPC_ALTIVEC)                 
>  \
>  {                                                                            
>  \

I am still pondering what is the better solution between passing a
pointer to an avr register or the avr register number.

Does someone has an opinion about that?

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net