Re: [Qemu-devel] [PATCH] Time drift again.

[Anthony Liguori]

Gleb Natapov wrote:
> +
>  RTCState *rtc_init(int base, qemu_irq irq)
>  {
>      RTCState *s;
> @@ -483,6 +532,9 @@ RTCState *rtc_init(int base, qemu_irq irq)
>      register_ioport_read(base, 2, 1, cmos_ioport_read, s);
>  
>      register_savevm("mc146818rtc", base, 1, rtc_save, rtc_load, s);
> +#ifdef TARGET_I386
> +    register_savevm("mc146818rtc-td", base, 1, rtc_save_td, rtc_load_td, s);
> +#endif
>   

This should be conditional on whether TDF is enabled or not (these 
fields are meaningless if it's not enabled).

Modulo documentation, I think this patch is just about the best we can 
do.  I'm inclined to commit this once you've sent out an updated patch 
unless anyone has major objections.

Regards,

Anthony Liguori