Re: [Qemu-devel] [PATCH 3/3] [QEMU] Add BIOS splash image

[Laurent Vivier]

Le 16 déc. 08 à 18:41, Blue Swirl a écrit :

> On 12/16/08, Laurent Vivier <address@hidden> wrote:
> > Le 16 déc. 08 à 17:16, Blue Swirl a écrit :
> >
> >
> >
> > > On 12/16/08, Laurent Vivier <address@hidden> wrote:
> > >
> > > > This patch adds to qemu the function needed to display a splash  
> > > > image
> > under
> > > > BIOS control through the firmware control device.
> > > >
> > > > It adds a "-splash" option allowing to specify the picture file  
> > > > name (a
> > .PNG)
> > > > to display. You can enable/disable a fade in, fade out and the  
> > > > bootmenu.
> > The
> > > > time to display the image can be also given (in seconds).
> > >
> > > Nice. But shouldn't this be more generic, I think we want to use  
> > > this
> > > on OpenBIOS/Sparc (or PPC) too?
> >
> > I think it is generic as it uses the firmware configuration device,  
> > we have
> > just to modify openbios to use it (I think sparc uses it to have  
> > ram size).
> > The only possible issue with this patch is it depends on libpnglite  
> > to read
> > the file.
>
> I meant that most of the code should not reside in pc.c, but in a  
> common file.

Yes, I just understood that it was what you meant. Perhaps in a  
"splash.c" file...
> > The "bootmenu=off" can be an alias to "auto-boot?=true"
>
> I missed the bootmenu part, how does it work?

It disables the "Press F12 to select a boot device" part.

Laurent
----------------------- Laurent Vivier ----------------------
"The best way to predict the future is to invent it."
- Alan Kay