Re: [Qemu-devel] [PATCH] Add rtl8139b

[Jamie Lokier]

Igor Kovalenko wrote:
> On Tue, Dec 16, 2008 at 10:19 PM, Jamie Lokier <address@hidden> wrote:
> > address@hidden wrote:
> >> +                        " ne2k_pci pcnet rtl8139 rtl8139b e1000\n");
> >
> > On seeing this in qemu output, and with no documentation, it suggests
> > "rtl8139b" is a later device revision than "rtl8139", and preferable
> > to use for new VMs.
> >
> > Imho it would be better to write " rtl8139b rtl8139 " and of course
> > document that rtl8139b is an older device than rtl8139.
> >
> 
> -net nic,model=rtl8139[,quirks=8139cplus|8139b] default to 8139cplus

Nice!  I'd change to [,revision=8139cplus|8139b], as it's not a quirk.

-- Jamie