[Qemu-devel] Re: [PATCH 3/8] v2: add info numa monitor command

[Anthony Liguori]

Andre Przywara wrote:
> Signed-off-by: Andre Przywara <address@hidden>
>
> # HG changeset patch
> # User Andre Przywara <address@hidden>
> # Date 1229430525 -3600
> # Node ID 0f3054b66373c2a8b65a5be6d83af63f807dd88f
> # Parent  a0a2e3026d4acffdce91b776d8c2d733767693c5
> add info numa command to the monitor
>
> diff -r a0a2e3026d4a -r 0f3054b66373 monitor.c
> --- a/monitor.c Tue Dec 16 13:28:24 2008 +0100
> +++ b/monitor.c Tue Dec 16 13:28:45 2008 +0100
> @@ -1281,6 +1281,20 @@ static void do_info_kvm(void)
>  #endif
>  }
>  
> +static void do_info_numa(void)
> +{
> +    int i, j;
> +
> +    term_printf("%d nodes\n", numnumanodes);
> +    for (i = 0; i < numnumanodes; i++) {
> +        term_printf("node %d cpus:", i);
> +        for (j = 0; j < 64; j++)
> +            if (node_to_cpus[i] & (1ULL << j)) term_printf(" %d", j);
>   

So the current code limits us to 64-cpus?  That's a pretty serious 
limitation IMHO.  I think that strongly suggests we're using the wrong 
structures for node_to_cpus--especially to be in the BIOS FW interface.

Regards,

Anthony Liguori