Re: [Qemu-devel] [PATCH 0/3] Add BIOS splash image support

[Daniel P. Berrange]

On Wed, Dec 17, 2008 at 04:04:57PM +0100, Kevin Wolf wrote:
> Jan Kiszka schrieb:
> > Gerd Hoffmann wrote:
> >> Jan Kiszka wrote:
> >>> Yes, please. I hate this artificial delay, specifically as I have to do
> >>> a lot of short boot tests where this contributes noticeably to their
> >>> execution time. But, as usual, it didn't hurt enough to make me hack a
> >>> patch yet. I'm willing to do this if we can agree on how it should be 
> >>> done.
> >> Show the boot menu only on case no "-boot whatever" cmd line option is
> >> present?
> > 
> > I would say only when there is -bootmenu as Gleb suggested. I'm half
> > done with this approach already.
> 
> I like Gerd's approach better as it doesn't introduce yet another
> command line parameter. It makes sense to me that you don't want a menu
> if you specify -boot.

Actually no it doesn't. The reason the original author wrote this 
boot menu patch was explicitly so that if you had used a '-boot d'
arg, you could do a one-time override from the BIOS screen.

One other alternative to added a brand new arg is to just allow an extra
meta-character in -boot arg to indicate that it should prompt or not

  -boot d    (use cdrom)

vs

  -boot d+   (default cdrom, prompt to allow override)

but perhaps that's a bit obtuse

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|