Re: [Qemu-devel] [PATCH 0 of 7] DisplayState interface change

[Andreas Färber]

Am 18.12.2008 um 20:12 schrieb Stefano Stabellini:

> this is the forth update of the "DisplayState interface change"  
> series.
>
> This update fixes the few remaining issue raised last time.
>
> The series is made of 7 patches:
>
> 1) accessors again
> some other substitutions in hw/sm501.c;
>
> 2) remove bgr
> the new DisplayState interface does not contain any host specific
> display detail, it is an abstraction of the backend display, hence we
> don't need to memorize the bgr flag in DisplayState.
> The frontend must be able to handle a bgr display by itself, in fact  
> sdl
> is perfectly capable of that;

Sorry if I've asked that before, but doesn't this (and 3) require  
changes to non-SDL backends as well, especially Cocoa?
The MacBook display appeared to be bgr so that TCX had to be adapted  
and bgr forcedly set to 1 in cocoa.m (r2974).

Thanks,
Andreas

> 3) DisplayState interface change
> this is the big patch that actually changes the interface;
>
> 4) vnc improvements
> this patch introduces DisplaySurfaces in vnc, simplifying the code.
>
> 5) graphical_console_init change
> this is the patch that changes the graphical_console_init function
> to return an allocated DisplayState instead of a QEMUConsole, as  
> Anthony
> suggested.
> This patch does *not* include any required changes to any devices,  
> these
> changes come with the two following patches.
>
> 6) machine changes
> this patch changes the QEMUMachine init functions of all the machine  
> types
> not to take a DisplayState as an argument because is not needed any
> more;
>
> 7) graphic device changes
> this patch updates the graphic device code to use the new
> graphical_console_init function.
>
> Patch number 5 requires also 6 and 7 to compile.
>
> More comments on single patches.
>
> Cheers,
>
> Stefano