qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack


From: Carl-Daniel Hailfinger
Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack
Date: Tue, 23 Dec 2008 20:43:24 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.17) Gecko/20080922 SUSE/1.1.12-0.1 SeaMonkey/1.1.12

On 23.12.2008 19:30, Blue Swirl wrote:
> On 12/23/08, Justin Chevrier <address@hidden> wrote:
>   
>>  It also appears that the code referenced in the link loops infinitely due 
>> to a missing: "max_sensei--;" which is present in the Linux Kernel's 
>> equivalent code.
>>     
>
> This one:
> http://fxr.watson.org/fxr/source/drivers/block/floppy.c?v=linux-2.4.22;im=bigexcerpts#L1800
>
> Adding max_sensei-- to OpenBIOS allows it to survive your previous
> patch, which caused an infinite loop earlier:
>
> floppy_motor_off
> SENSEI c0 00
> SENSEI c0 00
> SENSEI c0 00
> SENSEI c0 00
> status = 80, reply_buffer= c0 0
>   

Can you send a patch for this issue to upstream OpenBIOS?

Thanks!

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]