Re: [Qemu-devel] [PATCH] target-ppc: add integer Altivec instructions, take 2

[Aurelien Jarno]

On Tue, Dec 30, 2008 at 07:09:42PM -0800, Nathan Froyd wrote:
> This is a follow-on to:
> 
>   http://lists.gnu.org/archive/html/qemu-devel/2008-12/msg01000.html
> 
> as Aurelien asked me to modify the notation for defining instructions in
> target-ppc/translate.c.  Since that change touched nearly every patch in
> the series, I figured I would also take the opportunity to eliminate the
> VECTOR_FOR macros that my patch used as well.  I also fixed up various
> TCG errors that turned up under DEBUG_TCG.
> 
> I did, however, leave the VECTOR_FOR_INORDER_I macros in place; I think
> they are the clearest way to indicate that vectors are being iterated
> over in target-endian order.  Better than `#if defined(WORDS_BIGENDIAN)'
> all over the code, IMHO.
> 
> As the message in:
> 
>   http://lists.gnu.org/archive/html/qemu-devel/2008-12/msg01106.html
> 
> indicated, m{f,t}vscr seems to be broken in some way; the code looks
> correct to me, but I can't seem to puzzle out what's wrong with it.  All
> other instructions have been tested against an Altivec hardware
> implementation.  Except for the VSCR issue above, the simulated
> instructions perform identically to their hardware-implemented versions.
> 

Thanks for your great work. I have applied all the patches of the series
except the following ones, for which I have already send comments:

- Add GEN_VXRFORM{, 1} macros for subsequent instructions.
- Add vcmpequ{b, h, w} and vcmpgt{s, u}{b, h, w} instructions.
- Add m{f,t}vscr instructions.
- Add v{add, sub}{s, u}{b, h, w}s instructions.
- Add vs{l,r} instructions.
- Add vspltis{b,h,w} instructions.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net