Re: [Qemu-devel] [6136] Register reset handlers

[Avi Kivity]

Blue Swirl wrote:
> Revision: 6136
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6136
> Author:   blueswir1
> Date:     2008-12-28 18:27:10 +0000 (Sun, 28 Dec 2008)
>
> Log Message:
> -----------
> Register reset handlers
>
>
> Modified: trunk/hw/vga.c
> ===================================================================
> --- trunk/hw/vga.c      2008-12-28 15:45:20 UTC (rev 6135)
> +++ trunk/hw/vga.c      2008-12-28 18:27:10 UTC (rev 6136)
> @@ -1826,10 +1826,73 @@
>      s->last_height = -1;
>  }
>  
> -static void vga_reset(VGAState *s)
> +static void vga_reset(void *opaque)
>  {
> -    memset(s, 0, sizeof(VGAState));
> +    memset(s->sr, '\0', sizeof(s->sr));
> +    s->gr_index = 0;
> +    memset(s->gr, '\0', sizeof(s->gr));
> +    s->ar_index = 0;
> +    memset(s->ar, '\0', sizeof(s->ar));
> +    s->ar_flip_flop = 0;
> +    s->cr_index = 0;
> +    memset(s->cr, '\0', sizeof(s->cr));
>   

...

>      }
> +    qemu_register_reset(vga_reset, s);
> +    vga_reset(s);
>  }
>  
>   

This breaks cirrus - the reset handler tramples over some cirrus 
registers, and after reset graphic comes up in 640x480 resolution.  I'll 
follow up with a patch.

--
error compiling committee.c: too many arguments to function