[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] Redirect slirp traffic to/from qemu char
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] Redirect slirp traffic to/from qemu character device. |
Date: |
Wed, 07 Jan 2009 10:52:49 -0600 |
User-agent: |
Thunderbird 2.0.0.19 (X11/20090105) |
Gleb Natapov wrote:
Signed-off-by: Gleb Natapov <address@hidden>
---
slirp/libslirp.h | 5 ++-
slirp/main.h | 1 +
slirp/misc.c | 2 +
slirp/sbuf.c | 2 +
slirp/slirp.c | 62 +++++++++++++++++++++++++++++++++-
slirp/socket.c | 99 +++++++++++++++++++++++++++++++++++++++++++-----------
slirp/socket.h | 2 +
slirp/tcp_subr.c | 5 +++
8 files changed, 154 insertions(+), 24 deletions(-)
This patch breaks the Windows build.
In file included from /home/anthony/svn/qemu/slirp/slirp.h:215,
from /home/anthony/svn/qemu/slirp/slirp.c:24:
/home/anthony/svn/qemu/slirp/socket.h:90: warning: 'struct iovec'
declared inside parameter list
/home/anthony/svn/qemu/slirp/socket.h:90: warning: its scope is only
this definition or declaration, which is probably not what you want
/home/anthony/svn/qemu/slirp/slirp.c: In function 'slirp_select_poll':
/home/anthony/svn/qemu/slirp/slirp.c:458: warning: passing argument 2 of
'send' from incompatible pointer type
/home/anthony/svn/qemu/slirp/slirp.c: In function 'slirp_send':
/home/anthony/svn/qemu/slirp/slirp.c:749: warning: implicit declaration
of function 'qemu_chr_write'
/home/anthony/svn/qemu/slirp/slirp.c: In function 'slirp_socket_can_recv':
/home/anthony/svn/qemu/slirp/slirp.c:774: error: array type has
incomplete element type
/home/anthony/svn/qemu/slirp/slirp.c:774: warning: unused variable 'iov'
/home/anthony/svn/qemu/slirp/slirp.c: In function 'slirp_socket_recv':
/home/anthony/svn/qemu/slirp/slirp.c:800: warning: pointer targets in
passing argument 2 of 'soreadbuf' differ in signedness
You probably need to add an #include to get our version of struct iovec
for Windows.
Regards,
Anthony Liguori
- [Qemu-devel] [PATCH v2 0/5] Marry slirp and qemu character device., Gleb Natapov, 2009/01/05
- [Qemu-devel] [PATCH v2 1/5] Redirect slirp traffic to/from qemu character device., Gleb Natapov, 2009/01/05
- Re: [Qemu-devel] [PATCH v2 1/5] Redirect slirp traffic to/from qemu character device.,
Anthony Liguori <=
- [Qemu-devel] [PATCH v2 2/5] Add vmchannel command line option., Gleb Natapov, 2009/01/05
- [Qemu-devel] [PATCH v2 3/5] Add slirp_restrict option., Gleb Natapov, 2009/01/05
- [Qemu-devel] [PATCH v2 4/5] Add "restrict" and "ip" option to "user" net option, Gleb Natapov, 2009/01/05
- [Qemu-devel] [PATCH v2 5/5] Add support for vmchannel socket migration., Gleb Natapov, 2009/01/05
- Re: [Qemu-devel] [PATCH v2 0/5] Marry slirp and qemu character device., Anthony Liguori, 2009/01/05
- Re: [Qemu-devel] [PATCH v2 0/5] Marry slirp and qemu character device., Anthony Liguori, 2009/01/05