Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option

[Blue Swirl]

On 1/10/09, Trolle Selander <address@hidden> wrote:
> Paul Brook wrote:
>
> > On Friday 09 January 2009 12:45:47 Trolle Selander wrote:
> >
> >
> > > +#ifdef TARGET_SPARC
> > > +    vga_ram_size += (1024 * 1024);
> > > +#endif
> > >
> > >
> >
> > This looks pretty bogus.
> >
> >
> >
>  Possibly. The previous static definition added one meg to the default
>  VGA_RAM_SIZE if TARGET_SPARC was set, and I merely wanted to retain that
>  behavior. If someone who is familiar with the SPARC target and knows the
>  reason for the added meg of ram in the previous code can assure that
>  this won't be needed with the configurabe ram patch, I'll be happy to
>  drop that bit.

In 24 bit mode, TCX uses a 32 bit framebuffer, 32 bit control plane
(selects whether 24 bit mode or 8 bit mode is used for each pixel) and
there is still the 8 bit framebuffer, all full screen (1024x768) size.
This translates to 4 + 4 + 1 MB.

I think the -videoram switch should be disabled for targets with fixed
framebuffer hardware in machine description or with:
#if !defined(TARGET_SPARC) || defined(TARGET_SPARC64)