Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events

[Laurent Desnogues]

On Fri, Jan 16, 2009 at 1:14 PM, Kevin Wolf <address@hidden> wrote:
[..]
>> @@ -159,6 +159,12 @@ static void cpu_reset_model_id(CPUARMState *env, 
>> uint32_t id)
>>  void cpu_reset(CPUARMState *env)
>>  {
>>      uint32_t id;
>> +
>> +    if (qemu_loglevel_mask(CPU_LOG_RESET)) {
>> +        fprintf(logfile, "CPU Reset (CPU %d)\n", env->cpu_index);
>> +        cpu_dump_state(env, logfile, fprintf, 0);
>
> Shouldn't that be qemu_log() and log_cpu_state() now?

Yes. Sorry Jan :)

A trick to check things are done properly is to make sure you
don't ever use logfile or loglevel variables.


Laurent