qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [6362] Remove unused info_str parameter to pcnet_common_ini


From: Blue Swirl
Subject: [Qemu-devel] [6362] Remove unused info_str parameter to pcnet_common_init()
Date: Sat, 17 Jan 2009 20:47:10 +0000

Revision: 6362
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6362
Author:   blueswir1
Date:     2009-01-17 20:47:10 +0000 (Sat, 17 Jan 2009)

Log Message:
-----------
Remove unused info_str parameter to pcnet_common_init()

I noticed that pcnet_common_init() takes an unused 'info_str'
parameter, added in r2142.  Since then, we always pass "pcnet"
to register_savevm() (and never "lance").

Note that r6218 changed vc->info_str to "lance" for sun4m emulation.

On the assumption that it's not needed, this patch removes the
parameter.  If reverting the change in r2142, and registering with
"lance" would be preferable, I can submit a patch to do so.

Signed-off-by: Stuart Brady <address@hidden>

Modified Paths:
--------------
    trunk/hw/pcnet.c

Modified: trunk/hw/pcnet.c
===================================================================
--- trunk/hw/pcnet.c    2009-01-17 18:41:53 UTC (rev 6361)
+++ trunk/hw/pcnet.c    2009-01-17 20:47:10 UTC (rev 6362)
@@ -1929,7 +1929,7 @@
     return 0;
 }
 
-static void pcnet_common_init(PCNetState *d, NICInfo *nd, const char *info_str)
+static void pcnet_common_init(PCNetState *d, NICInfo *nd)
 {
     d->poll_timer = qemu_new_timer(vm_clock, pcnet_poll_timer, d);
 
@@ -2032,7 +2032,7 @@
     d->phys_mem_write = pci_physical_memory_write;
     d->pci_dev = &d->dev;
 
-    pcnet_common_init(d, nd, "pcnet");
+    pcnet_common_init(d, nd);
 }
 
 /* SPARC32 interface */
@@ -2106,6 +2106,6 @@
     d->phys_mem_read = ledma_memory_read;
     d->phys_mem_write = ledma_memory_write;
 
-    pcnet_common_init(d, nd, "lance");
+    pcnet_common_init(d, nd);
 }
 #endif /* TARGET_SPARC */






reply via email to

[Prev in Thread] Current Thread [Next in Thread]