Re: [Qemu-devel] [6344] graphical_console_init change (Stefano Stabellini)

[Aurelien Jarno]

On Sun, Jan 18, 2009 at 09:54:19PM +0900, Shin-ichiro KAWASAKI wrote:
> Hi.
>
> Anthony Liguori wrote:
>> Revision: 6344
>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6344
>> Author:   aliguori
>> Date:     2009-01-16 19:04:14 +0000 (Fri, 16 Jan 2009)
>>
>> Log Message:
>> -----------
>> graphical_console_init change (Stefano Stabellini)
>>
> (snip)
>
>> Modified: trunk/vl.c
>> ===================================================================
>> --- trunk/vl.c       2009-01-16 18:13:32 UTC (rev 6343)
>> +++ trunk/vl.c       2009-01-16 19:04:14 UTC (rev 6344)
> (snip)
>> +    /* just use the first displaystate for the moment */
>> +    ds = display_state;
>>      /* terminal init */
>> -    memset(&display_state, 0, sizeof(display_state));
>> -    ds->surface = qemu_create_displaysurface(640, 480, 32, 640 * 4);
>>      if (nographic) {
>>          if (curses) {
>>              fprintf(stderr, "fatal: -nographic can't be used with 
>> -curses\n");
>
> This commit seems to cause segmentation fault for boards which has no graphics
> display.  I saw the fault when I working with my SE7750 board support patch, 
> and
> invoking with -nographic options. The fault happens in 
> dump_display_init(ds) within the 'if (nographic)' block quoted above.  
> The argument ds is NULL because
> no graphic board initialize it, I guess.  Some null check for ds or dummy ds 
> might
> be needed, for such cases.
>

This is reproducible with other machines (like standard pc) using -vga
none.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net