[Qemu-devel] RE: [PATCH 7/9] powerpc/kvm: Add E500 core emulation

[Liu Yu]

> -----Original Message-----
> From: address@hidden 
> [mailto:address@hidden On Behalf Of Liu Yu-B13201
> Sent: Monday, January 19, 2009 6:55 PM
> To: Hollis Blanchard
> Cc: address@hidden; address@hidden
> Subject: RE: [PATCH 7/9] powerpc/kvm: Add E500 core emulation
> 
> 
> > -----Original Message-----
> > From: address@hidden 
> > [mailto:address@hidden On Behalf Of Hollis Blanchard
> > Sent: Saturday, January 17, 2009 2:03 AM
> > To: Liu Yu-B13201
> > Cc: address@hidden; address@hidden
> > Subject: RE: [PATCH 7/9] powerpc/kvm: Add E500 core emulation
> > 
> > On Fri, 2009-01-16 at 15:51 +0800, Liu Yu wrote:
> > > 
> > > I still want to fixup guest memory size at certain 
> > alignment boundary,
> > > so that KVM can handle the mmu easily.
> > 
> > How about "ram_size &= ~(256<<20)" then?
> > 
> > The code that you copied is more complicated because it's 
> > trying to fill
> > in SDRAM banks which can only support a small range of fixed sizes.
> > Since you don't have that problem, I think you should simplify.
> > 
> 
> I am not sure should I support more complicated sizes such as 
> 256 + 128
> + 64 = 448 MB

Hmm...,  I could use "ram_size &= ~(64<<20)"