[Qemu-devel] Re: [PATCH 1/5] Add target memory mapping API

[Avi Kivity]

Anthony Liguori wrote:
> > +        if ((pd & ~TARGET_PAGE_MASK) != IO_MEM_RAM) {
> > +            if (done || bounce.buffer) {
> > +                break;
> > +            }
> > +            bounce.buffer = qemu_memalign(TARGET_PAGE_SIZE, 
> > TARGET_PAGE_SIZE);
> > +            bounce.addr = addr;
> > +            bounce.len = l;
> >   
>
> I like the bouncing approach.  Namely, that it never bounces more than 
> a page at a time.  I think that's clever.

I tried to make it as stupid as possible.  Looks like I failed.

> Could you add some documentation to this function?  Namely, making it 
> clear that it can return NULL and that if it does, the caller must retry.

Sure.

> If map() fails, how does the caller determine when to retry the mapping?

By reading the next patch :)

--
error compiling committee.c: too many arguments to function