Re: [Qemu-devel] Re: Extremely slow graphic updates

[Stefano Stabellini]

Stefano Stabellini wrote:

> I could reproduce this issue.
> The problem seems to be strictly related to the gui_timer:
> 
> Currently we set the gui_timer only if someone implements dpy_refresh.
> Since sdl implements dpy_refresh while vnc does not, when only vnc is
> enabled the gui_timer is never allocated.
> 
> The weird thing is that even if I change the gui_update function to be
> something like:
> 
> static void gui_update(void *opaque)
> {
>      uint64_t interval = GUI_REFRESH_INTERVAL;
>      DisplayState *ds = opaque;
>      DisplayChangeListener *dcl = ds->listeners;
> 
>      qemu_mod_timer(ds->gui_timer, interval + qemu_get_clock(rt_clock));
> }
> 
> Vnc still works correctly.
> So it doesn't matter the actual implementation of the function to be
> called, as long as it is called.
> 

It seems that the select in vl.c:main_loop_wait never returns unless
gui_timer is properly set.
Something tells me that it shouldn't work this way :)