Re: [Qemu-devel] [PATCH 4/6] replace cpu_physical_memory_rw

[Avi Kivity]

Glauber Costa wrote:
> This patch introduces a kvm version of cpu_physical_memory_rw.
> The main motivation is to bypass tcg version, which contains
> tcg-specific code, as well as data structures not used by kvm,
> such as l1_phys_map.
>
> In this patch, I'm using a runtime selection of which function
> to call, but the mid-term goal is to use function pointers in
> a way very close to which QEMUAccel used to be.
>   

You will need to trivially adjust this for cpu_physical_memory_map().

You're still allocating the page descriptors, right?

My feeling is that qemu could long term drop phys_ram_base and move to a 
slot based structure; most lookups will hit on the first access (the 
largest slot).  The main motivation is to enable memory hotplug.  Of 
course this shouldn't interfere with this patchset going in.

--
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.